Skip to content

Conversation

@6543
Copy link
Contributor

@6543 6543 commented Oct 19, 2025

close urfave/cli#2210
close #9

@6543 6543 marked this pull request as ready for review October 20, 2025 09:43
@6543 6543 requested a review from a team as a code owner October 20, 2025 09:43
@6543
Copy link
Contributor Author

6543 commented Oct 20, 2025

If it is squashmerged I let it as is ... else I will rebase stuff

plz tell me :)

@6543
Copy link
Contributor Author

6543 commented Oct 20, 2025

@dearchap refactored the code to be more streamline and different doc generation will use the same func to get default falue e.g. no extra for bool flags outside of getFlagDefaultValue()

@6543
Copy link
Contributor Author

6543 commented Oct 20, 2025

this also matches the behaviour we have from --help more ..:
example:

user@laptop[woodpecker] # ./dist/woodpecker-agent --help | grep -E 'false|true'
   --grpc-secure              should the connection ... a secure transport (default: false) [$WOODPECKER_GRPC_SECURE]
   --grpc-skip-insecure       should the grpc server certificate be verified, ... (default: true) [$WOODPECKER_GRPC_VERIFY]
   --healthcheck              enable healthcheck endpoint (default: true) [$WOODPECKER_HEALTHCHECK]
   --pretty                   enable pretty-printed debug output (default: false) [$WOODPECKER_DEBUG_PRETTY]
   --nocolor                  disable colored debug output, ... (default: true) [$WOODPECKER_DEBUG_NOCOLOR]
...

@6543 6543 requested a review from dearchap October 20, 2025 11:56
@dearchap dearchap merged commit 0333461 into urfave:main Oct 20, 2025
6 checks passed
@6543 6543 deleted the DefaultText branch October 20, 2025 15:16
@6543
Copy link
Contributor Author

6543 commented Oct 20, 2025

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DefaultText is not respected for generating documentation

2 participants