From c5da5f61bc973745544c780f4589a09001904f64 Mon Sep 17 00:00:00 2001
From: fgy <fanguangyu.fgy1995@bytedance.com>
Date: Tue, 25 Oct 2022 14:27:22 +0800
Subject: [PATCH] feat: modify go doc

---
 flag_test.go            | 27 +++++++++++++++++++++++++++
 godoc-current.txt       |  2 ++
 testdata/godoc-v2.x.txt |  2 ++
 3 files changed, 31 insertions(+)

diff --git a/flag_test.go b/flag_test.go
index d46c1a70f7..832b81844a 100644
--- a/flag_test.go
+++ b/flag_test.go
@@ -3384,3 +3384,30 @@ func TestSliceShortOptionHandle(t *testing.T) {
 		t.Fatal("Action callback was never called")
 	}
 }
+
+// Test issue #1541
+func TestCustomizedSliceFlagSeparator(t *testing.T) {
+	opts := []string{"opt1", "opt2", "opt3,op", "opt4"}
+	// set args for examples sake
+	os.Args = []string{"multi_values",
+		"--stringSlice=" + strings.Join(opts, ";"),
+	}
+	app := NewApp()
+	app.Name = "multi_values"
+	app.Flags = []Flag{
+		&StringSliceFlag{Name: "stringSlice"},
+	}
+	app.SliceFlagSeparator = ";"
+	app.Action = func(ctx *Context) error {
+		ret := ctx.StringSlice("stringSlice")
+		for idx, r := range ret {
+			if r != opts[idx] {
+				t.Fatalf("get %dth failed, wanted: %s, but get: %s", idx, opts[idx], r)
+			}
+		}
+		return nil
+	}
+
+	_ = app.Run(os.Args)
+	defaultSliceFlagSeparator = ","
+}
diff --git a/godoc-current.txt b/godoc-current.txt
index e16d6ab738..fadb7f8629 100644
--- a/godoc-current.txt
+++ b/godoc-current.txt
@@ -316,6 +316,8 @@ type App struct {
 	// cli.go uses text/template to render templates. You can
 	// render custom help text by setting this variable.
 	CustomAppHelpTemplate string
+	// SliceFlagSeparator is used to customize the separator for SliceFlag, the default is ","
+	SliceFlagSeparator string
 	// Boolean to enable short-option handling so user can combine several
 	// single-character bool arguments into one
 	// i.e. foobar -o -v -> foobar -ov
diff --git a/testdata/godoc-v2.x.txt b/testdata/godoc-v2.x.txt
index e16d6ab738..fadb7f8629 100644
--- a/testdata/godoc-v2.x.txt
+++ b/testdata/godoc-v2.x.txt
@@ -316,6 +316,8 @@ type App struct {
 	// cli.go uses text/template to render templates. You can
 	// render custom help text by setting this variable.
 	CustomAppHelpTemplate string
+	// SliceFlagSeparator is used to customize the separator for SliceFlag, the default is ","
+	SliceFlagSeparator string
 	// Boolean to enable short-option handling so user can combine several
 	// single-character bool arguments into one
 	// i.e. foobar -o -v -> foobar -ov