From 0b3b172855f485638581a31c74b8e3401d5f7c6e Mon Sep 17 00:00:00 2001 From: "lynn [they]" Date: Thu, 9 Jan 2020 17:53:28 -0800 Subject: [PATCH 1/8] Update README.md --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index e7fb3d7551..93179f3dd0 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,8 @@ cli === +checking to see if master is failing + [![Windows Build Status](https://ci.appveyor.com/api/projects/status/rtgk5xufi932pb2v?svg=true)](https://ci.appveyor.com/project/urfave/cli) [![GoDoc](https://godoc.org/github.com/urfave/cli?status.svg)](https://godoc.org/github.com/urfave/cli) From 3e125a186585dd767d925f497beae50103a49d2d Mon Sep 17 00:00:00 2001 From: Ajitem Sahasrabuddhe Date: Mon, 13 Jan 2020 10:52:14 +0530 Subject: [PATCH 2/8] use npx to run the package instead of npm installing it --- .github/workflows/cli.yml | 1 - build.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index 89cd822380..c47efc6ff5 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -44,7 +44,6 @@ jobs: mkdir -p $GOPATH/bin curl -L -o $GOPATH/bin/gfmrun "https://github.com/urfave/gfmrun/releases/download/v1.2.14/gfmrun-$(go env GOOS)-amd64-v1.2.14" chmod +x $GOPATH/bin/gfmrun - npm install markdown-toc - name: Run Tests run: | diff --git a/build.go b/build.go index 325552cd0f..941556801e 100644 --- a/build.go +++ b/build.go @@ -166,7 +166,7 @@ func TocActionFunc(c *cli.Context) error { filename = "README.md" } - err := runCmd("node_modules/.bin/markdown-toc", "-i", filename) + err := runCmd("npx markdown-toc", "-i", filename) if err != nil { return err } From fb0d7af151d7e30f131a344265b917b0353e7981 Mon Sep 17 00:00:00 2001 From: Ajitem Sahasrabuddhe Date: Mon, 13 Jan 2020 10:56:43 +0530 Subject: [PATCH 3/8] setup node to run markdown toc --- .github/workflows/cli.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index c47efc6ff5..ef22671b6f 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -28,6 +28,11 @@ jobs: with: go-version: ${{ matrix.go }} + - name: Use Node.js 10.x + uses: actions/setup-node@v1 + with: + node-version: 10.x + - name: Set GOPATH and PATH run: | echo "::set-env name=GOPATH::$(dirname $GITHUB_WORKSPACE)" From f4f10b5c16c9704b01c7cac7e946f7641b89ba57 Mon Sep 17 00:00:00 2001 From: Ajitem Sahasrabuddhe Date: Mon, 13 Jan 2020 10:57:42 +0530 Subject: [PATCH 4/8] fix dumb indentation error --- .github/workflows/cli.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index ef22671b6f..18336e810e 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -29,9 +29,9 @@ jobs: go-version: ${{ matrix.go }} - name: Use Node.js 10.x - uses: actions/setup-node@v1 - with: - node-version: 10.x + uses: actions/setup-node@v1 + with: + node-version: 10.x - name: Set GOPATH and PATH run: | From f0c866e24cc94877b0aa884ec31df99e34ba563f Mon Sep 17 00:00:00 2001 From: Ajitem Sahasrabuddhe Date: Mon, 13 Jan 2020 10:59:32 +0530 Subject: [PATCH 5/8] try install markdown-toc globally --- .github/workflows/cli.yml | 1 + build.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index 18336e810e..e076cec5f3 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -49,6 +49,7 @@ jobs: mkdir -p $GOPATH/bin curl -L -o $GOPATH/bin/gfmrun "https://github.com/urfave/gfmrun/releases/download/v1.2.14/gfmrun-$(go env GOOS)-amd64-v1.2.14" chmod +x $GOPATH/bin/gfmrun + npm install -g markdown-toc - name: Run Tests run: | diff --git a/build.go b/build.go index 941556801e..5a6415a63f 100644 --- a/build.go +++ b/build.go @@ -166,7 +166,7 @@ func TocActionFunc(c *cli.Context) error { filename = "README.md" } - err := runCmd("npx markdown-toc", "-i", filename) + err := runCmd("markdown-toc", "-i", filename) if err != nil { return err } From 1ba20ea977301c7da349110585648100ff436bb5 Mon Sep 17 00:00:00 2001 From: Ajitem Sahasrabuddhe Date: Mon, 13 Jan 2020 18:59:36 +0530 Subject: [PATCH 6/8] Update .github/workflows/cli.yml Co-Authored-By: Robert Liebowitz --- .github/workflows/cli.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index e076cec5f3..220cee2217 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -49,7 +49,7 @@ jobs: mkdir -p $GOPATH/bin curl -L -o $GOPATH/bin/gfmrun "https://github.com/urfave/gfmrun/releases/download/v1.2.14/gfmrun-$(go env GOOS)-amd64-v1.2.14" chmod +x $GOPATH/bin/gfmrun - npm install -g markdown-toc + npm install -g markdown-toc@1.2.0 - name: Run Tests run: | From c5a0ee66b04e48ce7988035d8f6391cbe2a3c199 Mon Sep 17 00:00:00 2001 From: Ajitem Sahasrabuddhe Date: Mon, 13 Jan 2020 19:01:37 +0530 Subject: [PATCH 7/8] Update README.md remove cli failing message --- README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/README.md b/README.md index 93179f3dd0..e7fb3d7551 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,6 @@ cli === -checking to see if master is failing - [![Windows Build Status](https://ci.appveyor.com/api/projects/status/rtgk5xufi932pb2v?svg=true)](https://ci.appveyor.com/project/urfave/cli) [![GoDoc](https://godoc.org/github.com/urfave/cli?status.svg)](https://godoc.org/github.com/urfave/cli) From c4dc71ebadb964d93609f56a1ccfd71553204a5b Mon Sep 17 00:00:00 2001 From: Ajitem Sahasrabuddhe Date: Mon, 13 Jan 2020 19:02:13 +0530 Subject: [PATCH 8/8] Update cli.yml update to nodejs 12 LTS --- .github/workflows/cli.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml index 220cee2217..8bacc6c010 100644 --- a/.github/workflows/cli.yml +++ b/.github/workflows/cli.yml @@ -28,10 +28,10 @@ jobs: with: go-version: ${{ matrix.go }} - - name: Use Node.js 10.x + - name: Use Node.js 12.x uses: actions/setup-node@v1 with: - node-version: 10.x + node-version: 12.x - name: Set GOPATH and PATH run: |