Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set App.ErrWriter in App.Setup() #1100

Merged
merged 2 commits into from Apr 2, 2020
Merged

Conversation

@Nokel81
Copy link

@Nokel81 Nokel81 commented Mar 31, 2020

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

This change fixes App.ErrWriter not being initialized in App.Setup() like App.Writer. It also removes the App.errWriter() private method since App.ErrWriter is now set directly.

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1096

Release Notes

(REQUIRED)

- `App.ErrWriter` now defaults to `os.Stderr` if not set.
Sebastian Malton
- Defaults to os.Stderr
- Remove the App.errWriter() function since it is no longer needed
@Nokel81 Nokel81 requested a review from urfave/cli as a code owner Mar 31, 2020
Copy link
Member

@lynncyrin lynncyrin left a comment

(must change) It's probably gonna be annoying to write, but I would like to see a test for this behavior!

Sebastian Malton
@codecov
Copy link

@codecov codecov bot commented Apr 1, 2020

Codecov Report

Merging #1100 into master will increase coverage by 0.19%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
+ Coverage   73.07%   73.26%   +0.19%     
==========================================
  Files          34       34              
  Lines        2488     2484       -4     
==========================================
+ Hits         1818     1820       +2     
+ Misses        564      559       -5     
+ Partials      106      105       -1
Impacted Files Coverage Δ
app.go 83.4% <66.66%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f9fbd...fed64f3. Read the comment docs.

@lynncyrin
Copy link
Member

@lynncyrin lynncyrin commented Apr 2, 2020

thanks!

@lynncyrin lynncyrin merged commit 95b323f into urfave:master Apr 2, 2020
12 checks passed
12 checks passed
ubuntu-latest @ Go 1.12
Details
ubuntu-latest @ Go 1.13
Details
ubuntu-latest @ Go 1.14
Details
macos-latest @ Go 1.12
Details
macos-latest @ Go 1.13
Details
macos-latest @ Go 1.14
Details
windows-latest @ Go 1.12
Details
windows-latest @ Go 1.13
Details
windows-latest @ Go 1.14
Details
test-docs
Details
codecov/patch 75.00% of diff hit (target 73.07%)
Details
codecov/project 73.27% (+0.20%) compared to 39f9fbd
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants