Set App.ErrWriter in App.Setup() #1100
Merged
Conversation
- Defaults to os.Stderr - Remove the App.errWriter() function since it is no longer needed
|
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 73.07% 73.26% +0.19%
==========================================
Files 34 34
Lines 2488 2484 -4
==========================================
+ Hits 1818 1820 +2
+ Misses 564 559 -5
+ Partials 106 105 -1
Continue to review full report at Codecov.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This change fixes
App.ErrWriter
not being initialized inApp.Setup()
likeApp.Writer
. It also removes theApp.errWriter()
private method sinceApp.ErrWriter
is now set directly.Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1096
Release Notes
(REQUIRED)