Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zsh_autocomplete): List files on tab with no completion options #1130

Merged
merged 1 commit into from May 4, 2020

Conversation

@oleorhagen
Copy link
Contributor

@oleorhagen oleorhagen commented May 3, 2020

What type of PR is this?

  • [x ] bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

Aligns zsh auto-completion functionality with the bash auto-completion

Which issue(s) this PR fixes:

Special notes for your reviewer:

Testing

Tested manually

New functionality: https://asciinema.org/a/EAYRIEVGTGNSS2gCGwSJ4Zw1i

Old functionality: https://asciinema.org/a/BfOZz4BHUGwjXMFptbmDHZocH

Release Notes

(REQUIRED)

List files on tab with zsh auto-completion when no completion candidates are available.
This will simply list the files in the current directory if there are no
auto-completion options available.

With this change, the zsh auto-completion will align with the functionality in
the bash auto-completion file provided.

New functionality: https://asciinema.org/a/EAYRIEVGTGNSS2gCGwSJ4Zw1i

Old functionality: https://asciinema.org/a/BfOZz4BHUGwjXMFptbmDHZocH

Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
@oleorhagen oleorhagen requested a review from urfave/cli as a code owner May 3, 2020
@oleorhagen oleorhagen requested review from lynncyrin and asahasrabuddhe and removed request for urfave/cli May 3, 2020
Copy link
Member

@saschagrunert saschagrunert left a comment

LGTM

Copy link
Member

@lynncyrin lynncyrin left a comment

Looks fine, although I would like if there was something akin to tests for this.

@lynncyrin lynncyrin merged commit 6102689 into urfave:master May 4, 2020
12 checks passed
12 checks passed
ubuntu-latest @ Go 1.12
Details
ubuntu-latest @ Go 1.13
Details
ubuntu-latest @ Go 1.14
Details
macos-latest @ Go 1.12
Details
macos-latest @ Go 1.13
Details
macos-latest @ Go 1.14
Details
windows-latest @ Go 1.12
Details
windows-latest @ Go 1.13
Details
windows-latest @ Go 1.14
Details
test-docs
Details
codecov/patch Coverage not affected when comparing 464c868...b27d899
Details
codecov/project 73.24% (+0.00%) compared to 464c868
Details
@oleorhagen
Copy link
Contributor Author

@oleorhagen oleorhagen commented May 5, 2020

Looks fine, although I would like if there was something akin to tests for this.

Yup, some tests for the auto-completion features (both bash and zsh) would have been nice. But I didn't see any in place as of now. I wonder how much effort it would be to bootstrap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants