Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added manual and script for PowerShell autocomplete #1139

Merged
merged 2 commits into from Oct 31, 2020
Merged

Conversation

@kirinnee
Copy link
Contributor

@kirinnee kirinnee commented May 18, 2020

What type of PR is this?

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

This adds documentation and script to enable autocomplete on both
PowerShell and PS Core on Windows (and other platforms)

Special notes for your reviewer:

Not sure how to automate testing

Testing

Following instructions added to the manual in a PowerShell environment

@kirinnee kirinnee requested a review from urfave/cli as a code owner May 18, 2020
@kirinnee kirinnee requested review from rliebz and asahasrabuddhe and removed request for urfave/cli May 18, 2020
Copy link
Member

@saschagrunert saschagrunert left a comment

LGTM, but I have no knowledge about the PowerShell. :)

@kirinnee
Copy link
Contributor Author

@kirinnee kirinnee commented May 30, 2020

Any updates? Or anything I need to improve before it can be merged?

Copy link
Member

@lynncyrin lynncyrin left a comment

LGTM!

@lynncyrin
Copy link
Member

@lynncyrin lynncyrin commented Jun 4, 2020

Oh, @kirinnee the docs tests are failing b/c you're missing a heading. Check the logs here => https://github.com/urfave/cli/pull/1139/checks?check_run_id=683967954

Copy link
Member

@lynncyrin lynncyrin left a comment

Echoing my last comment, you'll need to add PowerShell Support to the table of contents! Please do re-request me when you've done that 👍

@kirinnee
Copy link
Contributor Author

@kirinnee kirinnee commented Jun 8, 2020

Hi I have updated accordingly. Please lmk if there are more changes needed! Thank you!

Copy link
Member

@lynncyrin lynncyrin left a comment

🚢

@lynncyrin lynncyrin requested a review from saschagrunert Jun 8, 2020
@stale
Copy link

@stale stale bot commented Sep 6, 2020

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

@stale stale bot added the status/stale label Sep 6, 2020
@kirinnee
Copy link
Contributor Author

@kirinnee kirinnee commented Sep 8, 2020

Any updates?

@stale
Copy link

@stale stale bot commented Sep 8, 2020

This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant.

@stale stale bot removed the status/stale label Sep 8, 2020
Copy link
Member

@asahasrabuddhe asahasrabuddhe left a comment

LGTM

@rliebz rliebz merged commit 3629eb8 into urfave:master Oct 31, 2020
12 checks passed
12 checks passed
ubuntu-latest @ Go 1.12
Details
ubuntu-latest @ Go 1.13
Details
ubuntu-latest @ Go 1.14
Details
macos-latest @ Go 1.12
Details
macos-latest @ Go 1.13
Details
macos-latest @ Go 1.14
Details
windows-latest @ Go 1.12
Details
windows-latest @ Go 1.13
Details
windows-latest @ Go 1.14
Details
test-docs
Details
codecov/patch Coverage not affected when comparing 477292c...9523a34
Details
codecov/project 73.27% (+0.03%) compared to 477292c
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants