Bugfix: Remove version flag from commands with subcommands #1153
Conversation
command_test.go
Outdated
HideHelp: true, | ||
Action: func(c *Context) error { | ||
if len(c.App.VisibleFlags()) != 0 { | ||
t.Fatalf("unexpected flag on command") |
rliebz
Jun 18, 2020
Member
Nit: Since there's no formatting here, t.Fatal
is more appropriate.
Nit: Since there's no formatting here, t.Fatal
is more appropriate.
Irioth
Jun 18, 2020
Author
Contributor
fixed
fixed
Sure, added such one. |
I just tested it, and apparently the |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What type of PR is this?
What this PR does / why we need it:
This PR removes unexpected version flag on commands with subcommands.
Which issue(s) this PR fixes:
Fixes #1073
Testing
test added
Release Notes