bugfix: don't overwrite existing stringslice refence #1178
Merged
Conversation
fixes an issue where values set by environment var are not saved to existing stringslice reference.
alexcb
requested review from
saschagrunert and
rliebz
and removed request for
urfave/cli
alexcb
added a commit
to earthly/earthly
that referenced
this pull request
Aug 25, 2020
current master version of urfave/cli has a bug where values set by the environment var are not saved to the stringslice var. Once urfave/cli#1178 is merged, we can switch back to using the upstream version.
alexcb
added a commit
to earthly/earthly
that referenced
this pull request
Aug 25, 2020
current master version of urfave/cli has a bug where values set by the environment var are not saved to the stringslice var. Once urfave/cli#1178 is merged, we can switch back to using the upstream version. Co-authored-by: Alex Couture-Beil <alex@earthly.dev>
|
@saschagrunert can I get a review on this? |
|
Yep, LGTM |
|
thanks @saschagrunert , is there anything else that needs to be done before this can be merged? |
saschagrunert
merged commit f539894
into
urfave:master
12 checks passed
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
fixes an issue where values set by environment var are not saved to
existing stringslice reference.
Which issue(s) this PR fixes:
No issue was opened
Testing
Included a small unit test
Release Notes
(REQUIRED)