feature: Add a App.Reader that defaults to os.Stdin #1191
Merged
+45
−0
Conversation
stellirin
requested review from
saschagrunert and
rliebz
and removed request for
urfave/cli
|
LGTM |
|
I've been searching hours for a nice solution for testing stdin like this. Is there anyway I can help get it merged? |
|
Thanks @rliebz for merging that and thanks @stellirin for writing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Closes: #1190
Release Notes
(REQUIRED)