Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging mostynb report source of parse errors #1354

Merged
merged 6 commits into from May 22, 2022

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented Apr 19, 2022

(supersedes #1168)

What type of PR is this?

See #1168

mostynb and others added 3 commits Nov 3, 2020
If you allow a flag to be set from environment variables or files and
a parse error occurs from one of them, it is very useful for the error
message to mention where the value came from.

Without this, it can be difficult to notice an error caused by an
unexpected environment variable being set.

Implements #1167.
move bool to the end of the return arguments

remove "from " prefix in the source/fromWhere description

remove TODO notes from functions that don't currently perform error checking
…ynb/cli into mostynb-report_source_of_parse_errors
@meatballhat meatballhat requested a review from a team as a code owner Apr 19, 2022
@meatballhat meatballhat added kind/feature describes a code enhancement / feature request area/v2 relates to / is being considered for v2 labels Apr 21, 2022
@meatballhat meatballhat added this to the Release 2.5.0 milestone Apr 21, 2022
@meatballhat meatballhat changed the base branch from master to main Apr 21, 2022
@meatballhat meatballhat merged commit 60a6bf5 into main May 22, 2022
13 checks passed
@meatballhat meatballhat deleted the mostynb-report_source_of_parse_errors branch May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/feature describes a code enhancement / feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants