Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] fix CI, add Go 1.17.x and 1.18.x #1379

Merged
merged 1 commit into from Apr 28, 2022
Merged

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Apr 27, 2022

What type of PR is this?

  • cleanup

What this PR does / why we need it:

One test is failing with Go 1.17+ since it now panics instead of
returning an error. Catch the panic and consider the test passed.

With that out of the door, add Go 1.17.x and 1.18.x to the testing
matrix.

While at it, do not use && in run since it is executed by a shell with
set -e, thus making && redundant.

Which issue(s) this PR fixes:

None (AFAICS)

Special notes for your reviewer:

None

Testing

That's what we have CI for!

Release Notes

NONE

@kolyshkin kolyshkin requested a review from as a code owner Apr 27, 2022
One test is failing with Go 1.17+ since it now panics instead of
returning an error. Catch the panic and consider the test passed.

With that out of the door, add Go 1.17.x and 1.18.x to the testing
matrix.

While at it, do not use && in run since it is executed by a shell with
set -e, thus making && redundant.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@meatballhat meatballhat added the area/v1 label Apr 28, 2022
@meatballhat meatballhat added this to the Release 1.22.8 milestone Apr 28, 2022
Copy link
Member

@meatballhat meatballhat left a comment

Thank you! 🎉

go run build.go vet &&
go run build.go test &&
go run build.go vet
go run build.go test
Copy link
Member

@meatballhat meatballhat Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that the default is to run with set -e 😯 !

@meatballhat meatballhat merged commit 936bd2e into urfave:v1 Apr 28, 2022
6 checks passed
@kolyshkin kolyshkin mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants