Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a v2.x semver approval gate #1385

Merged
merged 4 commits into from May 7, 2022
Merged

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented May 4, 2022

What type of PR is this?

  • feature

What this PR does / why we need it:

This PR introduces an approval step to heighten awareness around changes to the v2.x API surface area. I'm targeting the generating-flags-again branch since this work is an extension of some work I've got in process there but I didn't want to make #1382 any bigger.

Which issue(s) this PR fixes:

N/A 馃槵

@meatballhat meatballhat requested a review from a team as a code owner May 4, 2022
@meatballhat meatballhat added area/v2 relates to / is being considered for v2 kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work labels May 5, 2022
@meatballhat meatballhat added this to the Release 2.x milestone May 5, 2022
Base automatically changed from generating-flags-again to main May 7, 2022
@meatballhat meatballhat merged commit c6f7393 into main May 7, 2022
12 checks passed
@meatballhat meatballhat deleted the semver-approval-gate branch May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants