Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate RequiredFlag and VisibleFlag implementations #1393

Merged
merged 1 commit into from May 9, 2022

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented May 8, 2022

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Generate each flag type's implementations of the RequiredFlag and VisibleFlag interfaces so that they do not need to be maintained separately/manually.

Which issue(s) this PR fixes:

N/A 馃槵

@meatballhat meatballhat added area/v2 relates to / is being considered for v2 kind/cleanup describes internal cleanup / maintaince labels May 8, 2022
@meatballhat meatballhat added this to the Release 2.x milestone May 8, 2022
@meatballhat meatballhat requested a review from a team as a code owner May 8, 2022
rliebz
rliebz approved these changes May 8, 2022
@meatballhat meatballhat merged commit c114605 into main May 9, 2022
12 checks passed
@meatballhat meatballhat deleted the generate-req-viz branch May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/cleanup describes internal cleanup / maintaince
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants