Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the v2 manual a bit #1421

Merged
merged 1 commit into from Jun 22, 2022
Merged

Clean up the v2 manual a bit #1421

merged 1 commit into from Jun 22, 2022

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented Jun 20, 2022

What type of PR is this?

  • cleanup
  • documentation

What this PR does / why we need it:

includes:

  • running each example through goimports
  • wrapping text at ~80 cols
  • consistently using &cli.App{...}
  • consistently using code example gates
  • removing trailing blankspace

Which issue(s) this PR fixes:

N/A 馃槵

includes:
- running each example through `goimports`
- wrapping text at ~80 cols
- consistently using `&cli.App{...}`
- consistently using code example gates
- removing trailing blankspace
@meatballhat meatballhat added kind/documentation describes a documentation update area/v2 relates to / is being considered for v2 kind/cleanup describes internal cleanup / maintaince labels Jun 20, 2022
@meatballhat meatballhat added this to the Release 2.x milestone Jun 20, 2022
@meatballhat meatballhat requested a review from a team as a code owner Jun 20, 2022
Copy link
Contributor

@joeycumines joeycumines left a comment

nit: I'd have made the formatting changes in a separate PR

@meatballhat
Copy link
Member Author

meatballhat commented Jun 22, 2022

@joeycumines Totally fair! 鉂わ笍

@meatballhat meatballhat merged commit 7d21dda into main Jun 22, 2022
13 checks passed
@meatballhat meatballhat deleted the docs-cleanups branch Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/cleanup describes internal cleanup / maintaince kind/documentation describes a documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants