Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp flag error when using help #1439

Merged
merged 1 commit into from Jul 20, 2022

Conversation

hmiyado
Copy link
Contributor

@hmiyado hmiyado commented Jul 18, 2022

What type of PR is this?

  • bug

What this PR does / why we need it:

TimestampFlag causes error when using help or -h.

image

The code reproduce this problem is here.
It is same to example in https://cli.urfave.org/v2/#timestamp-flag .

This PR fix this error.

Which issue(s) this PR fixes:

no issue.

Testing

manual testing.

Release Notes

Fix timestamp flag error when using help.

@hmiyado hmiyado requested a review from a team as a code owner Jul 18, 2022
Copy link
Member

@meatballhat meatballhat left a comment

Thank you, @hmiyado!

@meatballhat meatballhat merged commit c8147a4 into urfave:main Jul 20, 2022
12 of 13 checks passed
@hmiyado hmiyado deleted the fix-timestamp-getvalue branch Jul 20, 2022
@meatballhat meatballhat mentioned this pull request Oct 2, 2022
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants