Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and run urfave-cli-genflags via its Makefile #1526

merged 3 commits into from Oct 13, 2022


Copy link

@meatballhat meatballhat commented Oct 9, 2022

What type of PR is this?

  • bug
  • cleanup

What this PR does / why we need it:

Without this, running make generate can result in errors about missing because the top-level go.mod context is in use rather than the cmd/urfave-cli-genflags/go.mod.

For example, this failure in the v3-porting branch:

Which issue(s) this PR fixes:

NA 馃槵

so that `go.mod` files don't get all confused
@meatballhat meatballhat added kind/bug describes or fixes a bug kind/cleanup describes internal cleanup / maintaince labels Oct 9, 2022
@meatballhat meatballhat requested a review from a team as a code owner October 9, 2022 15:27
Copy link

Can this help avoid make dependency on go build golang/go#46687 ?

Copy link
Member Author

@abitrolly I don't think so (?) If anything, I'm adding more dependence on make here 馃槄 , although it's only for when one wants to run go generate.

Copy link

I see. If that doesn't affect cd cmd; go build then that's probably ok.

@meatballhat meatballhat merged commit 89e331f into main Oct 13, 2022
13 checks passed
@meatballhat meatballhat deleted the genflags-mod branch October 13, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
kind/bug describes or fixes a bug kind/cleanup describes internal cleanup / maintaince
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants