Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1543

Merged
merged 13 commits into from Oct 23, 2022
Merged

Spelling #1543

merged 13 commits into from Oct 23, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 23, 2022

What type of PR is this?

  • cleanup

What this PR does / why we need it:

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@02977c8#commitcomment-87654132

Which issue(s) this PR fixes:

Special notes for your reviewer:

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Testing

The action reports that the changes in this PR would make it happy: jsoref@d23e518

Release Notes

NONE

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref requested a review from a team as a code owner October 23, 2022 17:07
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most corrections automatically suggested by Google Sheets. All fault mine

@@ -15,7 +15,7 @@ _**( Put the version of urfave/cli that you are using here )**_

- [ ] Are you running the latest v1 release? The list of releases is [here](https://github.com/urfave/cli/releases).
- [ ] Did you check the manual for your release? The v1 manual is [here](https://github.com/urfave/cli/blob/main/docs/v1/manual.md).
- [ ] Did you perform a search about this problem? Here's the [Github guide](https://help.github.com/en/github/managing-your-work-on-github/using-search-to-filter-issues-and-pull-requests) about searching.
- [ ] Did you perform a search about this problem? Here's the [GitHub guide](https://help.github.com/en/github/managing-your-work-on-github/using-search-to-filter-issues-and-pull-requests) about searching.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brand

@@ -59,7 +59,7 @@ link a failing build here.
## Want to fix this yourself?

We'd love to have more contributors on this project! If the fix for
this bug is easily explained and very small, free free to create a
this bug is easily explained and very small, feel free to create a
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atypical correction

Copy link
Contributor

@abitrolly abitrolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abitrolly
Copy link
Contributor

I would probably squash it into one commit.

@jsoref
Copy link
Contributor Author

jsoref commented Oct 23, 2022

I'm happy to squash or let you squash-merge if you like.

@dearchap
Copy link
Contributor

@jsoref @abitrolly I've enabled squash commit for this repo. Go ahead and squash merge

@abitrolly abitrolly merged commit 7732a51 into urfave:main Oct 23, 2022
13 checks passed
@abitrolly
Copy link
Contributor

Done. Thanks. :D

@jsoref jsoref deleted the spelling branch October 23, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants