Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature:(issue_1550):Add support Int64Slice by read toml config file #1551

Merged
merged 5 commits into from Nov 4, 2022

Conversation

Edelweiss-Snow
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)


@Edelweiss-Snow Edelweiss-Snow requested a review from a team as a code owner October 28, 2022 11:49
dearchap
dearchap previously approved these changes Oct 28, 2022
@dearchap
Copy link
Contributor

@Edelweiss-Snow Can you run make in your local workspace ? You might have to do a make v2approve to get past this error.

@Edelweiss-Snow
Copy link
Contributor Author

@Edelweiss-Snow Can you run make in your local workspace ? You might have to do a make v2approve to get past this error.

I can run the program local workspace, I try to solve this error

Feature:(issue_1550):add test flag test function
@dearchap dearchap merged commit 190e5b6 into urfave:main Nov 4, 2022
12 of 13 checks passed
@dearchap
Copy link
Contributor

dearchap commented Nov 4, 2022

Thanks @Edelweiss-Snow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants