Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid duplication of help commands #1565

Merged
merged 1 commit into from Nov 4, 2022

Conversation

remiposo
Copy link
Contributor

@remiposo remiposo commented Nov 4, 2022

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

When a Subcommand called and failed to parse flags, ShowCommandHelp(cCtx.parentContext, c.Name) shows help msg.

Even though this subcommand already have a help command, ShowCommandHelp add another one.

Two help commands displayed in result!!

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

I am not sure how best to add test cases for this small change.
Please help if needed...

Release Notes

(REQUIRED)


@remiposo remiposo requested a review from a team as a code owner Nov 4, 2022
@dearchap dearchap merged commit e194a18 into urfave:main Nov 4, 2022
12 of 13 checks passed
@dearchap
Copy link
Contributor

dearchap commented Nov 4, 2022

thanks for the fix @remiposo

@remiposo remiposo deleted the avoid_duplication_of_help_commands branch Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants