Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable slice flag separator #1588

merged 4 commits into from Nov 18, 2022


Copy link

@feedmeapples feedmeapples commented Nov 16, 2022

What type of PR is this?

  • feature

What this PR does / why we need it:

Copy of #1582 for consuming with the stable v2

Allows to disable SliceFlagSeparator by setting DisableSliceFlagSeparator = true
Useful when processing JSON values as described here #1134 (comment) and here #1134 (comment)

Which issue(s) this PR fixes:

Fixes #1134 and specifically #1134 (comment)

Special notes for your reviewer:

(fill-in or delete this section)


New unit test TestFlagSplitMultiValues_Disabled

Release Notes

Added support for disabling comma `,` based SliceFlag separator 

@feedmeapples feedmeapples requested a review from a team as a code owner November 16, 2022 23:10
@dearchap dearchap merged commit 5f57616 into urfave:v2-maint Nov 18, 2022
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants