Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The `mesh_size` input to numbers #35

Merged
merged 4 commits into from May 29, 2019
Merged

The `mesh_size` input to numbers #35

merged 4 commits into from May 29, 2019

Conversation

@uribo
Copy link
Owner

@uribo uribo commented May 29, 2019

Summary

API changes to functions that take mesh_size. It has been changed to a numeric value in km unit instead of the mesh size string.

jpmesh::coords_to_mesh(141.3468, 43.06462, mesh_size = "10km")

to

jpmesh::coords_to_mesh(141.3468, 43.06462, mesh_size = 10)

Related issues

none

uribo added 2 commits May 29, 2019
@lintr-bot

This comment has been minimized.

Copy link

@lintr-bot lintr-bot commented on 14163d9 May 29, 2019

R/administration_mesh.R:17:19: warning: no visible global function definition for ‘code_reform’

checked_code <- code_reform(code)
                  ^~~~~~~~~~~

R/find_neighbor_mesh.R:17:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:32:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:104:15: warning: no visible global function definition for ‘cut_off’

neighbor <- cut_off(res) %>% unique()
              ^~~~~~~

R/find_neighbor_mesh.R:104:28: warning: no visible global function definition for ‘%>%’, Did you mean '%*%'?

neighbor <- cut_off(res) %>% unique()
                           ^~~

R/is_mesh.R:33:13: warning: no visible global function definition for ‘is_meshcode’

invisible(is_meshcode(meshcode))
            ^~~~~~~~~~~

R/is_mesh.R:39:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/latlon_to_mesh.R:49:22: warning: no visible global function definition for ‘eval_jp_boundary’

coords_evalated <- eval_jp_boundary(longitude, latitude)
                     ^~~~~~~~~~~~~~~~

R/mesh_to_latlon.R:14:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/rmesh.R:11:12: warning: no visible global function definition for ‘meshcode_set’

​    sample(meshcode_set(mesh_size = mesh_size), n)
           ^~~~~~~~~~~~

R/util.R:120:36: warning: no visible global function definition for ‘meshcode_set’

res <- meshcode[mesh_80km %in% c(meshcode_set(80))]
                                   ^~~~~~~~~~~~

This comment has been minimized.

Copy link

@lintr-bot lintr-bot replied May 29, 2019

R/administration_mesh.R:17:19: warning: no visible global function definition for ‘code_reform’

checked_code <- code_reform(code)
                  ^~~~~~~~~~~

R/find_neighbor_mesh.R:17:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:32:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:104:15: warning: no visible global function definition for ‘cut_off’

neighbor <- cut_off(res) %>% unique()
              ^~~~~~~

R/find_neighbor_mesh.R:104:28: warning: no visible global function definition for ‘%>%’, Did you mean '%*%'?

neighbor <- cut_off(res) %>% unique()
                           ^~~

R/is_mesh.R:33:13: warning: no visible global function definition for ‘is_meshcode’

invisible(is_meshcode(meshcode))
            ^~~~~~~~~~~

R/is_mesh.R:39:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/latlon_to_mesh.R:49:22: warning: no visible global function definition for ‘eval_jp_boundary’

coords_evalated <- eval_jp_boundary(longitude, latitude)
                     ^~~~~~~~~~~~~~~~

R/mesh_to_latlon.R:14:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/rmesh.R:11:12: warning: no visible global function definition for ‘meshcode_set’

​    sample(meshcode_set(mesh_size = mesh_size), n)
           ^~~~~~~~~~~~

R/util.R:120:36: warning: no visible global function definition for ‘meshcode_set’

res <- meshcode[mesh_80km %in% c(meshcode_set(80))]
                                   ^~~~~~~~~~~~

This comment has been minimized.

Copy link

@lintr-bot lintr-bot replied May 29, 2019

R/administration_mesh.R:17:19: warning: no visible global function definition for ‘code_reform’

checked_code <- code_reform(code)
                  ^~~~~~~~~~~

R/find_neighbor_mesh.R:17:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:32:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:104:15: warning: no visible global function definition for ‘cut_off’

neighbor <- cut_off(res) %>% unique()
              ^~~~~~~

R/find_neighbor_mesh.R:104:28: warning: no visible global function definition for ‘%>%’, Did you mean '%*%'?

neighbor <- cut_off(res) %>% unique()
                           ^~~

R/is_mesh.R:33:13: warning: no visible global function definition for ‘is_meshcode’

invisible(is_meshcode(meshcode))
            ^~~~~~~~~~~

R/is_mesh.R:39:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/latlon_to_mesh.R:49:22: warning: no visible global function definition for ‘eval_jp_boundary’

coords_evalated <- eval_jp_boundary(longitude, latitude)
                     ^~~~~~~~~~~~~~~~

R/mesh_to_latlon.R:14:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/rmesh.R:11:12: warning: no visible global function definition for ‘meshcode_set’

​    sample(meshcode_set(mesh_size = mesh_size), n)
           ^~~~~~~~~~~~

R/util.R:120:36: warning: no visible global function definition for ‘meshcode_set’

res <- meshcode[mesh_80km %in% c(meshcode_set(80))]
                                   ^~~~~~~~~~~~
@lintr-bot

This comment has been minimized.

Copy link

@lintr-bot lintr-bot commented on 2072b67 May 29, 2019

R/administration_mesh.R:17:19: warning: no visible global function definition for ‘code_reform’

checked_code <- code_reform(code)
                  ^~~~~~~~~~~

R/find_neighbor_mesh.R:17:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:32:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:104:15: warning: no visible global function definition for ‘cut_off’

neighbor <- cut_off(res) %>% unique()
              ^~~~~~~

R/find_neighbor_mesh.R:104:28: warning: no visible global function definition for ‘%>%’, Did you mean '%*%'?

neighbor <- cut_off(res) %>% unique()
                           ^~~

R/is_mesh.R:33:13: warning: no visible global function definition for ‘is_meshcode’

invisible(is_meshcode(meshcode))
            ^~~~~~~~~~~

R/is_mesh.R:39:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/latlon_to_mesh.R:49:22: warning: no visible global function definition for ‘eval_jp_boundary’

coords_evalated <- eval_jp_boundary(longitude, latitude)
                     ^~~~~~~~~~~~~~~~

R/mesh_to_latlon.R:14:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/rmesh.R:11:12: warning: no visible global function definition for ‘meshcode_set’

​    sample(meshcode_set(mesh_size = mesh_size), n)
           ^~~~~~~~~~~~

R/util.R:120:36: warning: no visible global function definition for ‘meshcode_set’

res <- meshcode[mesh_80km %in% c(meshcode_set(80))]
                                   ^~~~~~~~~~~~

This comment has been minimized.

Copy link

@lintr-bot lintr-bot replied May 29, 2019

R/administration_mesh.R:17:19: warning: no visible global function definition for ‘code_reform’

checked_code <- code_reform(code)
                  ^~~~~~~~~~~

R/find_neighbor_mesh.R:17:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:32:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:104:15: warning: no visible global function definition for ‘cut_off’

neighbor <- cut_off(res) %>% unique()
              ^~~~~~~

R/find_neighbor_mesh.R:104:28: warning: no visible global function definition for ‘%>%’, Did you mean '%*%'?

neighbor <- cut_off(res) %>% unique()
                           ^~~

R/is_mesh.R:33:13: warning: no visible global function definition for ‘is_meshcode’

invisible(is_meshcode(meshcode))
            ^~~~~~~~~~~

R/is_mesh.R:39:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/latlon_to_mesh.R:49:22: warning: no visible global function definition for ‘eval_jp_boundary’

coords_evalated <- eval_jp_boundary(longitude, latitude)
                     ^~~~~~~~~~~~~~~~

R/mesh_to_latlon.R:14:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/rmesh.R:11:12: warning: no visible global function definition for ‘meshcode_set’

​    sample(meshcode_set(mesh_size = mesh_size), n)
           ^~~~~~~~~~~~

R/util.R:120:36: warning: no visible global function definition for ‘meshcode_set’

res <- meshcode[mesh_80km %in% c(meshcode_set(80))]
                                   ^~~~~~~~~~~~

This comment has been minimized.

Copy link

@lintr-bot lintr-bot replied May 29, 2019

R/administration_mesh.R:17:19: warning: no visible global function definition for ‘code_reform’

checked_code <- code_reform(code)
                  ^~~~~~~~~~~

R/find_neighbor_mesh.R:17:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:32:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/find_neighbor_mesh.R:104:15: warning: no visible global function definition for ‘cut_off’

neighbor <- cut_off(res) %>% unique()
              ^~~~~~~

R/find_neighbor_mesh.R:104:28: warning: no visible global function definition for ‘%>%’, Did you mean '%*%'?

neighbor <- cut_off(res) %>% unique()
                           ^~~

R/is_mesh.R:33:13: warning: no visible global function definition for ‘is_meshcode’

invisible(is_meshcode(meshcode))
            ^~~~~~~~~~~

R/is_mesh.R:39:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/latlon_to_mesh.R:49:22: warning: no visible global function definition for ‘eval_jp_boundary’

coords_evalated <- eval_jp_boundary(longitude, latitude)
                     ^~~~~~~~~~~~~~~~

R/mesh_to_latlon.R:14:11: warning: no visible global function definition for ‘mesh_size’

size <- mesh_size(meshcode)
          ^~~~~~~~~

R/rmesh.R:11:12: warning: no visible global function definition for ‘meshcode_set’

​    sample(meshcode_set(mesh_size = mesh_size), n)
           ^~~~~~~~~~~~

R/util.R:120:36: warning: no visible global function definition for ‘meshcode_set’

res <- meshcode[mesh_80km %in% c(meshcode_set(80))]
                                   ^~~~~~~~~~~~
@uribo uribo merged commit 6d446bd into master May 29, 2019
@uribo uribo deleted the feature/mesh_size_to_numeric branch May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.