Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwgeom no longer exports `st_make_valid` #32

Closed
edzer opened this issue Apr 10, 2020 · 2 comments
Closed

lwgeom no longer exports `st_make_valid` #32

edzer opened this issue Apr 10, 2020 · 2 comments

Comments

@edzer
Copy link

@edzer edzer commented Apr 10, 2020

Instead, package sf now does. This results in error on CRAN when upcoming lwgeom gets accepted, e.g.

    > test_check("jpndistrict")
    trying URL 'http://nlftp.mlit.go.jp/ksj/gml/data/P34/P34-14/P34-14_47_GML.zip'
    Content type 'application/zip' length 9427 bytes
    ==================================================
    downloaded 9427 bytes
    
    options:        ENCODING=cp932 
    Reading layer `P34-14_47' from data source `/home/hornik/tmp/scratch/RtmpL61OtX/P34-14_47_GML/P34-14_47.shp' using driver `ESRI Shapefile'
    Simple feature collection with 65 features and 4 fields
    geometry type:  POINT
    dimension:      XY
    bbox:           xmin: 123.0045 ymin: 24.06092 xmax: 131.2989 ymax: 27.03917
    geographic CRS: JGD2000
    ── 1. Error: Data (@test-util.R#4)  ────────────────────────────────────────────
    'st_make_valid' is not an exported object from 'namespace:lwgeom'
    Backtrace:
      1. testthat::expect_length(export_pref_80km_mesh(1), 40L)
      4. jpndistrict:::export_pref_80km_mesh(1)
      3. jpndistrict::jpn_pref(pref_code = code)
     11. lwgeom::st_make_valid(.)
     14. base::getExportedValue(pkg, name)

Please update jpndistrict and resubmit to CRAN to avoid errors in CRAN checks.

@uribo
Copy link
Owner

@uribo uribo commented Apr 10, 2020

Oops. Thanks, I'll fix that.

uribo added a commit that referenced this issue Apr 15, 2020
ref) #32
@uribo
Copy link
Owner

@uribo uribo commented Apr 20, 2020

jpndistrict v0.3.6 released.

@uribo uribo closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.