New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pool_timeout as a parameter in HTTPConnectionPool #1101

Open
csala opened this Issue Jan 20, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@csala

csala commented Jan 20, 2017

This issue is a follow up of this issue opened in the requests repository

As indicated in the file requests/packages/README.rst, if this is accepted, the changes will be first implemented and pushed here.

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Jan 20, 2017

Contributor

Is there a reason we need to do this? Requests can simply pass the appropriate option to urlopen or new_conn.

Contributor

Lukasa commented Jan 20, 2017

Is there a reason we need to do this? Requests can simply pass the appropriate option to urlopen or new_conn.

@csala

This comment has been minimized.

Show comment
Hide comment
@csala

csala Jan 20, 2017

@Lukasa You are right, strictly speaking there is no need to put it here and requests can pass it to urlopen.

But since this parameter controls the connection pool behaviour exactly as block and maxsize do, I think it's better to follow the same approach.

csala commented Jan 20, 2017

@Lukasa You are right, strictly speaking there is no need to put it here and requests can pass it to urlopen.

But since this parameter controls the connection pool behaviour exactly as block and maxsize do, I think it's better to follow the same approach.

@Lukasa

This comment has been minimized.

Show comment
Hide comment
@Lukasa

Lukasa Jan 20, 2017

Contributor

Yeah, I think that makes some sense.

Contributor

Lukasa commented Jan 20, 2017

Yeah, I think that makes some sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment