Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer create a context with specific ciphers #1462

Closed
nick-garcia opened this issue Oct 23, 2018 · 1 comment
Closed

Can no longer create a context with specific ciphers #1462

nick-garcia opened this issue Oct 23, 2018 · 1 comment
Labels
TLS

Comments

@nick-garcia
Copy link

@nick-garcia nick-garcia commented Oct 23, 2018

The recent change to remove support for Python 2.6 has made it so that the "ciphers" parameter of the create_urllib3_context function in ssl_.py no longer has any effect. The parameter is unused for the rest of the function.

This was working properly in Python 3.6, so I don't know why it was tagged as being Python 2.6 specific.

@sethmlarson sethmlarson added the TLS label Oct 23, 2018
@sethmlarson
Copy link
Member

@sethmlarson sethmlarson commented Oct 23, 2018

I see what happened here, the branch for that piece of code was incorrectly marked as being for Python 2.6 only but actually was for Python 2.6+. See: cb21598#diff-7c9a38cd64066636d0e73a2449a28640L294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.