-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Description
Since the codecov reports are noisy, we frequently merge pull requests that lower coverage or even completely break coverage upload.
Indeed, we're trained to look at status checks, but not at the coverage report. But codecov is able to report its results with a status check too:
But how can we enable that? I think the trick is to add a branch protection rule in Settings > Branches > Add rule and require the travis and appveyor statuses.
Here's an example from pquentin/urllib3:
For python-trio/trio and python-trio/urllib3, it looks like setting this was enough to see codecov checks. We can try to enforce the codecov checks too, and decide to sometimes ignore them when merging. Trio does not do that because they're actually quite noisy.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels

