Skip to content

Configure GitHub to require codecov checks #1727

@pquentin

Description

@pquentin

Since the codecov reports are noisy, we frequently merge pull requests that lower coverage or even completely break coverage upload.

Indeed, we're trained to look at status checks, but not at the coverage report. But codecov is able to report its results with a status check too:

Capture d’écran 2019-10-31 à 17 01 46

But how can we enable that? I think the trick is to add a branch protection rule in Settings > Branches > Add rule and require the travis and appveyor statuses.

Here's an example from pquentin/urllib3:

Capture d’écran 2019-10-31 à 16 55 56

For python-trio/trio and python-trio/urllib3, it looks like setting this was enough to see codecov checks. We can try to enforce the codecov checks too, and decide to sometimes ignore them when merging. Trio does not do that because they're actually quite noisy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions