Skip to content

Proxies should use proxy_ssl_context when connecting via ProxyConfig.use_forwarding_for_https = True #2577

Closed

Description

@sethmlarson

This was discovered in #2558 and discussed with @jalopezsilva on Discord. The gist is it appears that we're using HTTPSConnection.ssl_context to connect to HTTPS proxies when using use_forwarding_with_https = True mode. This is likely caused by us treating the proxy like it's the origin when we have proxies in "forwarding" mode and previously we didn't have a forwarding mode for HTTPS.

Minimum requirements

💵 You can get paid to complete this issue! Please read the docs for more information.

  • When ProxyConfig.use_forwarding_with_https = True and ssl_context is specified:
    • If proxy_ssl_context is specified then error out with ValueError
    • If proxy_ssl_context isn't specified:
      • On 1.26.x emit a DeprecationWarning instructing to switch to proxy_ssl_context and set the value of ssl_context to proxy_ssl_context
      • On 2.x raise a ValueError that proxy_ssl_context should be used, not ssl_context.
  • Only proxy_ssl_context should be used for creating the connection to proxies in all modes (HTTP->HTTPS, HTTPS->HTTP, HTTPS->HTTPS, in forwarding/tunnel modes).
  • Remove the skip to test_proxy_https_target_tls_error added in 9f4d05c

Activity

  1. added
    💰 Bounty $500If you complete this issue we'll pay you $500 on OpenCollective!
    and removed on Jun 21, 2022
  2. added 4 commits that reference this issue on Jun 28, 2022
    c933a71
    929fba8
    7a45ff8
    6b3430f
  3. fyunusa commented on Aug 13, 2022

    @fyunusa

    Hi @sethmlarson have this issue been fixed ?
    I propose this patch for the 2.x version

    if use_forwarding_for_https == True and proxy_ssl_context != None:
                if isinstance(proxy_ssl_context, ssl.SSLContext) != True:
                    self.proxy_config = ProxyConfig(proxy_ssl_context, use_forwarding_for_https)
    
                elif proxy_ssl_context == ssl.SSLContext:
                    raise ValueError(
                        "proxy ssl context should be used, not ssl context"
                    )
    
  4. pquentin commented on Aug 19, 2022

    @pquentin
    Member

    You will need a pull request with tests before we can review your code.

  5. fyunusa commented on Aug 19, 2022

    @fyunusa

    OK @pquentin noted I'll work on that also

  6. sethmlarson commented on Aug 19, 2022

    @sethmlarson
    MemberAuthor

    @umarfarouk98 this issue is already being worked on by @avi364 I think in #2651?

  7. fyunusa commented on Aug 19, 2022

    @fyunusa

    OK yeah, I see that

  8. sg3-141-592 commented on Jan 15, 2024

    @sg3-141-592
    Contributor

    Hey @abebeos , I only ever got as far as adding the ValueError exception and a unit test for it. I'm not going to be finishing this change so feel free to reuse anything that's useful off my draft PR.

  9. alexprabhat99 commented on Sep 21, 2024

    @alexprabhat99
    Contributor

    Hi @sethmlarson
    Is this issue fixed or still accepting PRs?

  10. changed the title [-]Proxies should use proxy_ssl_context when connecting via ProxyConfig.use_forwarding_with_https = True[/-] [+]Proxies should use proxy_ssl_context when connecting via ProxyConfig.use_forwarding_for_https = True[/+] on Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

TLS💰 Bounty $500If you complete this issue we'll pay you $500 on OpenCollective!

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions