Should BaseHTTPResponse.readable() return False?

[pquentin]

As mentioned by @franekmagiera in #2712 (comment), it's surprising for BaseHTTPResponse to return True in readable() as read() is not implemented. If we need to change this, doing it before the urllib3 2.0 release will avoid a breaking change. Should we keep True, change to false False or raise NotImplementedError?

[sethmlarson]

To match with the io module we'll return False here. io.IOBase doesn't define read but does define readable which returns False.

[pquentin]

For the record, IOBase does mention read:

Even though IOBase does not declare read() or write() because their signatures will vary, implementations and clients should consider those methods part of the interface. Also, implementations may raise a ValueError (or UnsupportedOperation) when operations they do not support are called.

https://docs.python.org/3/library/io.html#io.IOBase