You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned by @franekmagiera in #2712 (comment), it's surprising for BaseHTTPResponse to return True in readable() as read() is not implemented. If we need to change this, doing it before the urllib3 2.0 release will avoid a breaking change. Should we keep True, change to false False or raise NotImplementedError?
The text was updated successfully, but these errors were encountered:
Even though IOBase does not declare read() or write() because their signatures will vary, implementations and clients should consider those methods part of the interface. Also, implementations may raise a ValueError (or UnsupportedOperation) when operations they do not support are called.
As mentioned by @franekmagiera in #2712 (comment), it's surprising for
BaseHTTPResponse
to returnTrue
inreadable()
asread()
is not implemented. If we need to change this, doing it before the urllib3 2.0 release will avoid a breaking change. Should we keepTrue
, change to falseFalse
or raiseNotImplementedError
?The text was updated successfully, but these errors were encountered: