Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestBrokenPipe.test_ignore_broken_pipe_errors fails on macOS 12 (Monterey) #2770

Closed
pquentin opened this issue Nov 8, 2022 · 1 comment · Fixed by #3246
Closed

TestBrokenPipe.test_ignore_broken_pipe_errors fails on macOS 12 (Monterey) #2770

pquentin opened this issue Nov 8, 2022 · 1 comment · Fixed by #3246

Comments

@pquentin
Copy link
Member

pquentin commented Nov 8, 2022

We're using macos-latest in CI, and about two weeks ago GitHub Actions upgraded from macOS 11.7 (Big Sur) to macOS 12.6 (Monterey). Since then, test_ignore_broken_pipe_errors fails reliably like this:

Traceback (most recent call last):
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/connectionpool.py", line 732, in urlopen
    httplib_response = self._make_request(
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/connectionpool.py", line 444, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/connection.py", line 355, in request
    self.send(chunk)
  File "/Users/runner/hostedtoolcache/Python/3.8.14/x64/lib/python3.8/http/client.py", line 972, in send
    self.sock.sendall(data)
ConnectionResetError: [Errno 54] Connection reset by peer

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/runner/work/urllib3/urllib3/test/with_dummyserver/test_socketlevel.py", line 2023, in test_ignore_broken_pipe_errors
    r = pool.request("POST", "/", body=buf)
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/_request_methods.py", line 117, in request
    return self.request_encode_body(
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/_request_methods.py", line 216, in request_encode_body
    return self.urlopen(method, url, **extra_kw)
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/connectionpool.py", line 799, in urlopen
    retries = retries.increment(
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/util/retry.py", line 467, in increment
    raise reraise(type(error), error, _stacktrace)
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/util/util.py", line 36, in reraise
    raise value.with_traceback(tb)
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/connectionpool.py", line 732, in urlopen
    httplib_response = self._make_request(
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/connectionpool.py", line 444, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/Users/runner/work/urllib3/urllib3/.nox/test-3-8/lib/python3.8/site-packages/urllib3/connection.py", line 355, in request
    self.send(chunk)
  File "/Users/runner/hostedtoolcache/Python/3.8.14/x64/lib/python3.8/http/client.py", line 972, in send
    self.sock.sendall(data)
urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(54, 'Connection reset by peer'))

This test is already disabled in Windows, so we may have to do the same on macOS 12+.

@pquentin
Copy link
Member Author

pquentin commented Nov 8, 2022

My early 2015 MacBook is unfortunately stuck on macOS 11 so I can't simply help with debugging. I'm considering using a service like https://www.scaleway.com/en/hello-m1/ where renting a machine running macOS 12 costs a few euros per day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant