Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix deadlocks with pool_block=True and retries #1174
Cool, this seems like we're getting a bit closer!
We definitely still need tests for these, but I'd be happy to take a patch in this form. We'll also want to add
read() calls prior to the
release in the two
return branches as well, but if you'd rather not deal with it straight away we can handle those in a separate PR.
Fab, so all we need now is some testing! You up for doing that?
@@ Coverage Diff @@ ## master #1174 +/- ## ====================================== Coverage 100% 100% ====================================== Files 21 21 Lines 1973 1979 +6 ====================================== + Hits 1973 1979 +6
Cool, this is looking pretty good! We're much closer here now, I have a few smaller notes in the diff.
Alright very nice! One small problem with coverage and we'll be good to go!