Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move urllib3 to src/urllib3 #1409

Merged
merged 1 commit into from Jul 4, 2018
Merged

Move urllib3 to src/urllib3 #1409

merged 1 commit into from Jul 4, 2018

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Jul 3, 2018

When tests are outside the main package, tox recommends putting the main package under an 'src' directory to ensure that the installed package is tested, not the source. This layout has other benefits, too.

We actually ran into this issue in the async support branch: the installation step adds the sync version by removing async/await keywords, so that's the only way to make tox work in that branch.

cc @njsmith

When tests are outside the main package, tox recommends putting the main
package under an 'src' directory to ensure that the installed package is
tested, not the source[0] . This layout has other benefits, too. [1]

[0]: https://docs.pytest.org/en/latest/goodpractices.html
[1]: https://blog.ionelmc.ro/2014/05/25/python-packaging/#the-structure
@pquentin
Copy link
Member Author

@pquentin pquentin commented Jul 3, 2018

SecureTransport failure on Python 3.7: https://travis-ci.org/urllib3/urllib3/jobs/399539365, trying again.

@pquentin pquentin closed this Jul 3, 2018
@pquentin pquentin reopened this Jul 3, 2018
@pquentin
Copy link
Member Author

@pquentin pquentin commented Jul 3, 2018

Now a TestHTTPS.test_client_no_intermediate failure on Python 2.6 on macOS: https://travis-ci.org/urllib3/urllib3/jobs/399564364, trying again.

@pquentin pquentin closed this Jul 3, 2018
@pquentin pquentin reopened this Jul 3, 2018
@sigmavirus24
Copy link
Contributor

@sigmavirus24 sigmavirus24 commented Jul 3, 2018

I'm generally in favor of this.... once tests pass of course :)

@pquentin
Copy link
Member Author

@pquentin pquentin commented Jul 3, 2018

Now a TestHTTPS.test_client_no_intermediate failure on Python 3.4 on Windows: https://ci.appveyor.com/project/urllib3/urllib3/build/1.0.176/job/tenbr6b2hj4crfbg. Trying again!

@pquentin pquentin closed this Jul 3, 2018
@pquentin pquentin reopened this Jul 3, 2018
@pquentin
Copy link
Member Author

@pquentin pquentin commented Jul 3, 2018

Yay, all tests pass! I've seen those failures before: I don't think they're related to this change.

@pquentin
Copy link
Member Author

@pquentin pquentin commented Jul 3, 2018

Oh, no, they don't actually pass. This time it's three macOS failures, two TestHTTPS.test_client_no_intermediate and one TestSocketClosing.test_delayed_body_read_timeout.

@pquentin pquentin closed this Jul 3, 2018
@pquentin pquentin reopened this Jul 3, 2018
@pquentin
Copy link
Member Author

@pquentin pquentin commented Jul 3, 2018

Sorry for the noise, but I think it's useful to know what tests are flaky? Or maybe I should focus on fixing test_client_no_intermediate.

The latest failure? TestHTTPS.test_client_no_intermediate on macOS and Python 3.7: https://travis-ci.org/urllib3/urllib3/jobs/399606514.

@pquentin pquentin closed this Jul 3, 2018
@pquentin pquentin reopened this Jul 3, 2018
@sethmlarson
Copy link
Member

@sethmlarson sethmlarson commented Jul 4, 2018

If you could fix test_client_no_intermediate I think I'd owe you something IRL. :)

@sigmavirus24 sigmavirus24 merged commit c41fa8c into urllib3:master Jul 4, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pquentin pquentin deleted the pquentin:src-dir branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.