This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke urllib3 on Google App Engine, which also doesn't have _tunnel_host in its implementation of httplib. The if getattr(self, '_tunnel_host', None): part should go back in.
Below is a stacktrace of the error. Note that this is pure urllib3, no requests are being used.
Traceback (most recent call last):
File "/project/updater/search_backend.py", line 1353, in setup
File "/project/libs/elasticsearch_five/transport.py", line 312, in perform_request
status, headers, data = connection.perform_request(method, url, params, body, ignore=ignore, timeout=timeout)
File "/project/libs/elasticsearch_five/connection/http_urllib3.py", line 114, in perform_request
response = self.pool.urlopen(method, url, body, retries=False, headers=self.headers, **kw)
File "/project/libs/urllib3/connectionpool.py", line 600, in urlopen
File "/project/libs/urllib3/connectionpool.py", line 343, in _make_request
File "/project/libs/urllib3/connectionpool.py", line 839, in _validate_conn
File "/project/libs/urllib3/connection.py", line 304, in connect
AttributeError: 'VerifiedHTTPSConnection' object has no attribute '_tunnel_host'
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.