Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ambiguous description of backoff_factor #1436

Merged
merged 1 commit into from Sep 9, 2018

Conversation

@Mattwmaster58
Copy link
Contributor

@Mattwmaster58 Mattwmaster58 commented Sep 8, 2018

Change from ^ to **. Programmers not familiar with python might assume the ^ is the exponent operator, when in fact it is the bitwise XOR operator. This change will remove the ambiguity.

Change from `^` to `**`. Programmers not familiar with python might assume the ^ is the exponent operator, when in fact it is the bitwise XOR operator. This change will remove the ambiguity.
@codecov-io
Copy link

@codecov-io codecov-io commented Sep 8, 2018

Codecov Report

No coverage uploaded for pull request base (master@e38125d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1436   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?      21           
  Lines             ?    1790           
  Branches          ?       0           
========================================
  Hits              ?    1790           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
src/urllib3/util/retry.py 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38125d...d04dbda. Read the comment docs.

Copy link
Member

@sethmlarson sethmlarson left a comment

I agree that this change is definitely better in a Python context. Thanks for this! 🎉

@sethmlarson sethmlarson merged commit 1821e73 into urllib3:master Sep 9, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.