Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing key_server_hostname variable #1449

Merged
merged 1 commit into from Oct 12, 2018
Merged

Conversation

@swg0101
Copy link
Contributor

@swg0101 swg0101 commented Oct 5, 2018

Allow key_server_hostname to be specified when initializing a PoolManager to allow custom SNI to be overridden.

Allow key_server_hostname to be specified when initializing a PoolManager to allow custom SNI to be overridden.
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 5, 2018

Codecov Report

Merging #1449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1449   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          21      21           
  Lines        1811    1811           
======================================
  Hits         1811    1811
Impacted Files Coverage Δ
src/urllib3/poolmanager.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3636f...449aaba. Read the comment docs.

Copy link
Member

@sethmlarson sethmlarson left a comment

This change I believe is correct. Follows from #1397

@sethmlarson sethmlarson merged commit a0964d9 into urllib3:master Oct 12, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sethmlarson
Copy link
Member

@sethmlarson sethmlarson commented Oct 12, 2018

Thanks @swg0101! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.