Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't percent encode tilde characters in URL #1692

merged 1 commit into from Sep 24, 2019


Copy link

Erroneously left the tilde ~ character out of the UNRESERVED_CHARS section causing them to be percent-encoded. This caused issues with users that had tildes in paths.

Closes #1683.
Closes #1684.

Copy link

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for cleaning up this file.

Copy link
Member Author

Thanks for the review @pquentin! :)

@sethmlarson sethmlarson merged commit 9167b58 into urllib3:master Sep 24, 2019
@sethmlarson sethmlarson deleted the tilde-encoding branch September 24, 2019 16:04
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Tilde characters encoded in URLs starting in 1.25.4
2 participants