Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TLS 1.3 support in SecureTransport #1703

Merged
merged 1 commit into from Oct 4, 2019

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Oct 2, 2019

It's not actually supported by the OS. In other words, instead of trying
TLS 1.3 and being forced to fallback on TLS 1.2, we just use TLS 1.2 by
default.

Closes #1674.

It's not actually supported by the OS. In other words, instead of trying
TLS 1.3 and being forced to fallback on TLS 1.2, we just use TLS 1.2 by
default.
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #1703 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1703   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          22       22           
  Lines        2006     2006           
=======================================
  Hits         2001     2001           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08cf7fd...c143b64. Read the comment docs.

@sethmlarson sethmlarson merged commit cef15a1 into urllib3:master Oct 4, 2019
@sethmlarson
Copy link
Member

Thanks @pquentin! 🎉

@pquentin
Copy link
Member Author

pquentin commented Oct 5, 2019

Thank you for the review!

@pquentin pquentin deleted the remove-securetransport-tls13 branch Oct 28, 2019
@pquentin pquentin mentioned this pull request Nov 11, 2019
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
It's not actually supported by the OS. In other words, instead of trying
TLS 1.3 and being forced to fallback on TLS 1.2, we just use TLS 1.2 by
default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecureTransport module does not actually support TLS 1.3
3 participants