Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up queue test by using a zero timeout #1711

Merged
merged 1 commit into from Oct 29, 2019

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Oct 28, 2019

Queue.get() accepts any non-negative number, so 0 works. It's also not
arbitrary like 1 was, and the test suite now takes one less second to
run!

I've workon on this as part of #1706

Queue.get() accepts any non-negative number, so 0 works. It's also not
arbitrary like 1 was, and the test suite now takes one less second to
run!
@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #1711 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1711   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          22       22           
  Lines        2006     2006           
=======================================
  Hits         1999     1999           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e81f9...6e46210. Read the comment docs.

@sethmlarson sethmlarson merged commit 1733719 into urllib3:master Oct 29, 2019
2 checks passed
@pquentin pquentin deleted the queue-timeout branch Oct 30, 2019
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this issue Mar 16, 2022
Queue.get() accepts any non-negative number, so 0 works. It's also not
arbitrary like 1 was, and the test suite now takes one less second to
run!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants