Prefer pytest.raises to self.fail #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It reuses a standard mechanism, is less verbose and avoids including code that is never executed.
Codecov Report
@@ Coverage Diff @@
## master #1712 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 22 22
Lines 2006 2006
=======================================
Hits 1999 1999
Misses 7 7Continue to review full report at Codecov.
|
sethmlarson
approved these changes
Oct 29, 2019
Member
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
This is definitely better, thanks @pquentin!
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
It reuses a standard mechanism, is less verbose and avoids including code that is never executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It reuses a standard mechanism, is less verbose and avoids including
code that is never executed.