Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve chunked flag when re-calling urlopen() in retry loop #1715

Merged
merged 3 commits into from Oct 29, 2019

Conversation

lmvlmv
Copy link
Contributor

@lmvlmv lmvlmv commented Oct 28, 2019

No description provided.

@lmvlmv
Copy link
Contributor Author

lmvlmv commented Oct 28, 2019

Attempts to fix #1714

@lmvlmv lmvlmv marked this pull request as ready for review Oct 28, 2019
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #1715 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1715   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          22       22           
  Lines        2006     2006           
=======================================
  Hits         1999     1999           
  Misses          7        7
Impacted Files Coverage Δ
src/urllib3/connectionpool.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e81f9...6f4da3b. Read the comment docs.

Copy link
Member

@pquentin pquentin left a comment

Thank you for your pull request! That's a nice and important fix, and thank you for helping urllib3 and requests play well together.

There are two other recursive calls that are also missing chunked=chunked, but we'll worry about them later.

I added a test to make sure that we don't his this issue again, so someone else will need to review this :)

@lmvlmv
Copy link
Contributor Author

lmvlmv commented Oct 29, 2019

NP. Thanks for that. Couldn't get the test env working locally. Since the change to requests more people will be visiting this function call so good to get it fixed first. Not sure when the next requests release will be...

Copy link
Member

@sethmlarson sethmlarson left a comment

Wow, great catch!

@sethmlarson sethmlarson merged commit 31db282 into urllib3:master Oct 29, 2019
2 checks passed
@sethmlarson
Copy link
Member

sethmlarson commented Oct 29, 2019

Thanks @lmvlmv and @pquentin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants