-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve chunked flag when re-calling urlopen() in retry loop #1715
Conversation
Attempts to fix #1714 |
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 22 22
Lines 2006 2006
=======================================
Hits 1999 1999
Misses 7 7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request! That's a nice and important fix, and thank you for helping urllib3 and requests play well together.
There are two other recursive calls that are also missing chunked=chunked
, but we'll worry about them later.
I added a test to make sure that we don't his this issue again, so someone else will need to review this :)
NP. Thanks for that. Couldn't get the test env working locally. Since the change to requests more people will be visiting this function call so good to get it fixed first. Not sure when the next requests release will be... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great catch!
No description provided.