Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore comment next to its intended line #1720

Merged
merged 1 commit into from Oct 30, 2019

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Oct 30, 2019

I don't know what those errors mean, but I can tell that initially For OSX was next to errnor.EHOSTUNREACH: see #335. @shazow was right five years ago, because we're now using four lines anyway, and doing it from the start would have preserved the correct position. :)

@sethmlarson sethmlarson merged commit 3cff0a5 into urllib3:master Oct 30, 2019
2 checks passed
@pquentin pquentin deleted the clarify-comment branch Oct 30, 2019
@shazow
Copy link
Member

shazow commented Oct 30, 2019

Loool my prediction was off by almost 2 years though, I'll work on that for next time.

Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this issue Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants