Skip to content

Remove unused certs#1721

Merged
sethmlarson merged 2 commits into
urllib3:masterfrom
pquentin:remove-unused-certs
Oct 30, 2019
Merged

Remove unused certs#1721
sethmlarson merged 2 commits into
urllib3:masterfrom
pquentin:remove-unused-certs

Conversation

@pquentin
Copy link
Copy Markdown
Member

Preliminary work towards #1705

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 30, 2019

Codecov Report

Merging #1721 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1721   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          22       22           
  Lines        2006     2006           
=======================================
  Hits         1999     1999           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d68ef...87a6dc7. Read the comment docs.

Copy link
Copy Markdown
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't need these anymore after switching to Trustme anyways. :)

@sethmlarson sethmlarson merged commit 639dfda into urllib3:master Oct 30, 2019
@pquentin pquentin deleted the remove-unused-certs branch October 30, 2019 12:27
@pquentin
Copy link
Copy Markdown
Member Author

Right, but switching completely to trustme won't be that straightforward, I don't know when the transition will be complete.

Thank you for the review!

Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants