Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused certs #1721

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Remove unused certs #1721

merged 2 commits into from
Oct 30, 2019

Conversation

pquentin
Copy link
Member

Preliminary work towards #1705

@codecov-io
Copy link

codecov-io commented Oct 30, 2019 •
edited
Loading

Codecov Report

Merging #1721 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1721   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          22       22           
  Lines        2006     2006           
=======================================
  Hits         1999     1999           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d68ef...87a6dc7. Read the comment docs.

sethmlarson
sethmlarson approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't need these anymore after switching to Trustme anyways. :)

@sethmlarson sethmlarson merged commit 639dfda into urllib3:master Oct 30, 2019
@pquentin pquentin deleted the remove-unused-certs branch October 30, 2019 12:27
@pquentin
Copy link
Member Author

Right, but switching completely to trustme won't be that straightforward, I don't know when the transition will be complete.

Thank you for the review!

Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
@pquentin @sethmlarson
Remove unused certs and keys (urllib3#1721)
7eabc50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pquentin @codecov-io @sethmlarson