Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate certificate directory at runtime #1722

Closed
wants to merge 6 commits into from

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Oct 30, 2019

Instead of storing it in git.

Done as part of #1705

@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #1722 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1722   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          22       22           
  Lines        2006     2006           
=======================================
  Hits         1999     1999           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2fe7be...9ebf150. Read the comment docs.

@pquentin
Copy link
Member Author

pquentin commented Oct 30, 2019

I just found out about http://doc.pytest.org/en/latest/tmpdir.html#the-tmpdir-fixture, so I pushed a new commit here

@pquentin
Copy link
Member Author

pquentin commented Oct 31, 2019

This pull request includes commits from #1724, so please review/merge #1724 first so that we have a record of it in the history.

tmp_path relies on pathlib/pathlib2, which is more future-proof.
@pquentin
Copy link
Member Author

pquentin commented Nov 3, 2019

This is also ready for review. :) But again, #1724 should be merged first.

@sethmlarson
Copy link
Member

sethmlarson commented Nov 4, 2019

Is there a conflict on this PR? Do we need these changes still?

@pquentin
Copy link
Member Author

pquentin commented Nov 4, 2019

This was merged as part of #1725. Thanks! Closing.

@pquentin pquentin closed this Nov 4, 2019
@pquentin pquentin deleted the dynamic-ca-dir branch Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants