Generate certificate directory at runtime#1722
Closed
pquentin wants to merge 6 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 22 22
Lines 2006 2006
=======================================
Hits 1999 1999
Misses 7 7Continue to review full report at Codecov.
|
Member
Author
|
I just found out about http://doc.pytest.org/en/latest/tmpdir.html#the-tmpdir-fixture, so I pushed a new commit here |
pquentin
force-pushed
the
dynamic-ca-dir
branch
from
63165f2 to
94380c2
Compare
Member
Author
This was not possibly until now because of functool.wraps for older Pythons.
Instead of storing it in git.
In order to support older Python versions.
pquentin
force-pushed
the
dynamic-ca-dir
branch
from
94380c2 to
bf84e6c
Compare
tmp_path relies on pathlib/pathlib2, which is more future-proof.
Member
Author
|
This is also ready for review. :) But again, #1724 should be merged first. |
sethmlarson
approved these changes
Nov 4, 2019
Member
|
Is there a conflict on this PR? Do we need these changes still? |
Member
Author
|
This was merged as part of #1725. Thanks! Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of storing it in git.
Done as part of #1705