Merged
Conversation
It turns out that without turning this one it's difficult to list exactly the tests that failed.
The default pytest tracebacks are really verbose: for each function in the stack they include the whole function until the exception, and the representation of its parameters. On the other hand, native tracebacks are way more concise, showing only two lines for each function and exception chains. The benefits of switching to native tracebacks: * The useful information fits in one screen * Python trains us to read those tracebacks from day one * We avoid the verbosity of showing the source code: we can already see it in GitHub and our editors * While we lose the information about parameters, I've never found this information to be useful I've been using this configuration for a few months now and never looked back!
Codecov Report
@@ Coverage Diff @@
## master #1723 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 22 22
Lines 2006 2006
=======================================
Hits 1999 1999
Misses 7 7Continue to review full report at Codecov.
|
sethmlarson
reviewed
Oct 30, 2019
Member
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Thanks for fixing the line ending issue! I don't have an opinion on the tracebacks, so we'll give these a whirl. :)
sethmlarson
approved these changes
Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's important here to read (and merge?) commit by commit, because the first commit creates a lot of noise. This first commit is not strictly needed, but git reminds me in every
git diffthat noxfile.py is the only urllib3 file using DOS lines, which is quite annoying. 😄