Fix flaky test_timeout #1729
Merged
Fix flaky test_timeout #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is about timeouts, we don't need to test _make_request specifically here.
It's used throughout the test so it's better to explain that it's a short timeout.
We had an interesting test failure in CI where this test failed twice in a row: we were expecting a timeout in 0.001 seconds, but both times it took more than one second! How can this happen? Well, when we ask a request to timeout after N seconds, here's what we know: * the request will time out, eventually * it won't timeout before those N seconds * it could timeout a long time after those N seconds, especially on a busy CI service Let's take advantage of those facts by specifying a request-specific timeout that's longer than the pool-level timeout and making sure that the timeout was long indeed. We still test that the request-specific timeout overrides the pool-level timeout, but will stop failing on busy CI services.
Codecov Report
@@ Coverage Diff @@
## master #1729 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 22 22
Lines 2006 2006
=======================================
Hits 1999 1999
Misses 7 7Continue to review full report at Codecov.
|
sethmlarson
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an interesting test failure in CI where this test failed twice in a row: we were expecting a timeout in 0.001 seconds, but both times it took more than one second!
How can this happen? Well, when we ask a request to timeout after N seconds, here's what we know:
Let's take advantage of those facts by specifying a request-specific timeout that's longer than the pool-level timeout and making sure that the timeout was long indeed.
We still test that the request-specific timeout overrides the pool-level timeout, but will stop failing on busy CI services.
(I'd like to think that this is easier to read and merge commit by commit.)