Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode fragment into target #1732

merged 2 commits into from Nov 4, 2019


Copy link

@sethmlarson sethmlarson commented Nov 4, 2019

We shouldn't be adding fragment to HTTP request targets. Also fixes a small bug where empty queries didn't parse.

Fixes #1731

@sethmlarson sethmlarson requested a review from pquentin Nov 4, 2019
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #1732 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1732      +/-   ##
+ Coverage   99.65%   99.7%   +0.04%     
  Files          22      22              
  Lines        2006    2003       -3     
- Hits         1999    1997       -2     
+ Misses          7       6       -1
Impacted Files Coverage Δ
src/urllib3/util/ 99.48% <100%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b36ad...33bfb5e. Read the comment docs.

Copy link

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

I edited the first post to mention that it fixes #1731, not #1703. Interestingly, the CI passed, but GitHub did not see it.

Copy link

pquentin commented Nov 4, 2019

Closing/reopening to convince GitHub that this works

@pquentin pquentin closed this Nov 4, 2019
@pquentin pquentin reopened this Nov 4, 2019
@pquentin pquentin merged commit 5665d6a into urllib3:master Nov 4, 2019
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
* Don't encode fragment into target

* Add entry in CHANGES.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'groups' on simple PoolManager.request
3 participants