Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve chunked parameter #1734

Merged
merged 2 commits into from Nov 7, 2019
Merged

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Nov 5, 2019

As promised in #1715

cc @lmvlmv @sethmlarson

The lint fails because of #1733.

@sethmlarson sethmlarson closed this Nov 5, 2019
@sethmlarson sethmlarson reopened this Nov 5, 2019
@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #1734 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1734   +/-   ##
======================================
  Coverage    99.7%   99.7%           
======================================
  Files          22      22           
  Lines        2003    2003           
======================================
  Hits         1997    1997           
  Misses          6       6
Impacted Files Coverage Δ
src/urllib3/connectionpool.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6996da3...8709bd5. Read the comment docs.

@pquentin
Copy link
Member Author

pquentin commented Nov 5, 2019

Rebased on top of master to get the lint fix.

@pquentin
Copy link
Member Author

pquentin commented Nov 5, 2019

This is a typical case where the codecov report makes no sense, this change does not affect line coverage at all!

@pquentin pquentin requested a review from sethmlarson Nov 5, 2019
@pquentin
Copy link
Member Author

pquentin commented Nov 5, 2019

Okay the codecov report now looks good.

@sethmlarson sethmlarson merged commit 5dce4e0 into urllib3:master Nov 7, 2019
@pquentin pquentin mentioned this pull request Nov 11, 2019
@pquentin pquentin deleted the chunked-retries branch Nov 30, 2019
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants