Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.4 #1774

Merged
merged 1 commit into from Jan 6, 2020
Merged

Drop Python 3.4 #1774

merged 1 commit into from Jan 6, 2020

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jan 6, 2020

Python 3.4 reached its end-of-life on 2019-03-18 and represents <4% of our daily downloads.

This is #1686 rebased on top of master. It got reverted because we were waiting for a good release to happen.

This should also fix the CI error noticed in #1750.

It reached its end-of-life on 2019-03-18 and represents <4% of our
daily downloads.
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Quentin! :)

@sethmlarson sethmlarson merged commit 734e028 into urllib3:master Jan 6, 2020
@pquentin pquentin deleted the drop-python34 branch Jan 6, 2020
@pquentin
Copy link
Member Author

pquentin commented Jan 6, 2020

Thank you for the review!

Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
It reached its end-of-life on 2019-03-18 and represents <4% of our
daily downloads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants