Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send 'User-Agent' twice if header is binary #2047

Merged
merged 1 commit into from Nov 11, 2020

Conversation

@sethmlarson
Copy link
Member

@sethmlarson sethmlarson commented Nov 11, 2020

Previously if b"user-agent" was sent for a non-chunked request then we'd emit multiple User-Agent headers, this closes that gap. This commit will need to be backported to 1.26

@codecov
Copy link

@codecov codecov bot commented Nov 11, 2020

Codecov Report

Merging #2047 (ebe7051) into master (00f1769) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2047   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         2297      2297           
=========================================
  Hits          2297      2297           
Impacted Files Coverage Δ
src/urllib3/connection.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f1769...ebe7051. Read the comment docs.

@sethmlarson sethmlarson added this to the v1.26 milestone Nov 11, 2020
@sethmlarson sethmlarson merged commit 74d6be1 into urllib3:master Nov 11, 2020
16 of 17 checks passed
@sethmlarson sethmlarson deleted the user-agent-sent-twice branch Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants