Skip to content

Remove always True condition - #2159

Merged
sethmlarson merged 1 commit into
urllib3:mainfrom
pquentin:remove-always-true-if
Feb 12, 2021
Merged

Remove always True condition#2159
sethmlarson merged 1 commit into
urllib3:mainfrom
pquentin:remove-always-true-if

Conversation

@pquentin

Copy link
Copy Markdown
Member

Now that we only support Python 3.6+, check_hostname always exists.

Now that we only support Python 3.6+, check_hostname always exists.
@codecov

codecov Bot commented Feb 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2159 (d407581) into main (780c644) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         2214      2215    +1     
=========================================
+ Hits          2214      2215    +1     
Impacted Files Coverage Δ
src/urllib3/util/ssl_.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780c644...ef19b9a. Read the comment docs.

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sethmlarson
sethmlarson merged commit c67806d into urllib3:main Feb 12, 2021
@pquentin
pquentin deleted the remove-always-true-if branch March 8, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants