Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove always True condition #2159

merged 1 commit into from Feb 12, 2021


Copy link

Now that we only support Python 3.6+, check_hostname always exists.

Now that we only support Python 3.6+, check_hostname always exists.
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #2159 (d407581) into main (780c644) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2159   +/-   ##
  Coverage   100.00%   100.00%           
  Files           25        25           
  Lines         2214      2215    +1     
+ Hits          2214      2215    +1     
Impacted Files Coverage Δ
src/urllib3/util/ 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780c644...ef19b9a. Read the comment docs.

Copy link

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sethmlarson sethmlarson merged commit c67806d into urllib3:main Feb 12, 2021
@pquentin pquentin deleted the remove-always-true-if branch March 8, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants