Bring coverage back to 100% #2167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All calls to reraise() are in branches where value is truthy, so we can't reach that code.
Codecov Report
@@ Coverage Diff @@
## main #2167 +/- ##
===========================================
+ Coverage 99.95% 100.00% +0.04%
===========================================
Files 25 25
Lines 2221 2219 -2
===========================================
- Hits 2220 2219 -1
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
|
The coverage is back to 100%, and the CI failure is #2171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All calls to reraise() are in branches where value is truthy, so we can't reach that code. (I don't explain why this only showed up in coverage when we... added types to reraise, though.)
It seemed better than testing a case that we never hit in real code. (I guess that not using reraise at all would be better, but that seems difficult to achieve.)