Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last place that allowed a missing check_hostname #2170

Merged
merged 1 commit into from Mar 8, 2021

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Mar 8, 2021

This is a followup of #2159

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #2170 (f9186f3) into main (dc6284c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2170   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          25       25           
  Lines        2221     2221           
=======================================
  Hits         2220     2220           
  Misses          1        1           
Impacted Files Coverage Δ
src/urllib3/connection.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc6284c...f9186f3. Read the comment docs.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit 3a46093 into urllib3:main Mar 8, 2021
@pquentin pquentin deleted the missing-check-hostname branch September 24, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants